fix: pull-request fetch for private user profiles #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `prs.ts` and consolidated pull request fetching.
Unused exports (1)
|
Add @octokit/types to package.json and refactor issue utils.
Change debug to info log level and streamline retry mechanism.
|
@0x4007 On the good news: it works, I successfully retrieve the items! However on the less good news, there are other places where GitHub search is used and they subsequently break as well. I will have to provide a fix for all of them which broadens the scope on this task, on it. |
Refactor code to use fallback methods for better error handling.
Refactored to use `octokit.rest` namespace for paginate methods.
Introduce mock context and data to validate pull request retrieval.
0x4007
approved these changes
Oct 30, 2024
gentlementlegen
merged commit b960b84
into
ubiquity-os-marketplace:development
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70
QA: Meniole#41 (comment) (@ubiquity-ubiquibot has its information private)